Topic: Test version for 0.2 (Read 129848 times)

DougTheC · « **Reply #1050 on:** January 06, 2021, 11:38:04 pm »

More typos as noticed:

(click to show/hide)

Freimann · « **Reply #1051 on:** January 07, 2021, 03:18:31 am »

The new 'autorest' status icon doesn't display. It's just the gray 'no picture found' icon.

Goldo · « **Reply #1052 on:** January 07, 2021, 04:48:38 pm »

Quote from: DougTheC on January 05, 2021, 10:18:24 pm

With new patch, before starting a new game; hadn't updated with other patches in last two weeks.

Start menu, Preferences, Game Options gave this error (reproducible):

(click to show/hide)
Code: [Select]
I'm sorry, but an uncaught exception occurred. While running game code: File "game/BKscreens.rpy", line 7270, in execute screen h_content(): File "game/BKscreens.rpy", line 7270, in execute screen h_content(): File "game/BKscreens.rpy", line 7277, in execute viewport xsize 0.8: File "game/BKscreens.rpy", line 7282, in execute frame: File "game/BKscreens.rpy", line 7284, in execute has vbox xfill True File "game/BKscreens.rpy", line 7371, in execute hbox spacing 6: File "game/BKscreens.rpy", line 7372, in execute hbox box_wrap True: File "game/BKscreens.rpy", line 7374, in execute for status in [("away", "away.webp"), ("farm", "farm.webp"), ("rest", "rest.webp"), ("scheduled", "scheduled.webp"), ("half-shift", "half.webp"), ("master bedroom", "master.webp"), ("work&whore", "ww.webp"), ("naked", "naked.webp"), ("negative fixation", "negfix.webp"), ("not naked", "not_naked.webp"), ("not work&whore", "not_ww.webp")]: File "game/BKscreens.rpy", line 7376, in execute if status: File "game/BKscreens.rpy", line 7377, in execute button action ToggleDict(persistent.show_girl_status, status[0]) hovered SetScreenVariable("current_status", status[0]) unhovered SetScreenVariable("current_status", ""): File "game/BKscreens.rpy", line 7378, in execute if persistent.show_girl_status[status[0]]: KeyError: u'scheduled' -- Full Traceback ------------------------------------------------------------ Full traceback: File "renpy/common/_layout/screen_main_menu.rpym", line 28, in script python hide: File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\ast.py", line 914, in execute renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\python.py", line 2028, in py_exec_bytecode exec bytecode in globals, locals File "renpy/common/_layout/screen_main_menu.rpym", line 28, in <module> python hide: File "renpy/common/_layout/screen_main_menu.rpym", line 35, in _execute_python_hide ui.interact() File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\ui.py", line 297, in interact rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 2702, in interact repeat, rv = self.interact_core(preloads=preloads, trans_pause=trans_pause, **kwargs) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 3094, in interact_core root_widget.visit_all(lambda i : i.per_interact()) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 541, in visit_all d.visit_all(callback, seen) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 541, in visit_all d.visit_all(callback, seen) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 541, in visit_all d.visit_all(callback, seen) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\screen.py", line 430, in visit_all callback(self) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\core.py", line 3094, in <lambda> root_widget.visit_all(lambda i : i.per_interact()) File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\screen.py", line 440, in per_interact self.update() File "C:\Users\Leno19\Documents\Humor\s\Games\BrothelKing\Brothel_King 0.2 test2\renpy\display\screen.py", line 625, in update self.screen.function(**self.scope) File "game/BKscreens.rpy", line 7270, in execute screen h_content(): File "game/BKscreens.rpy", line 7270, in execute screen h_content(): File "game/BKscreens.rpy", line 7277, in execute viewport xsize 0.8: File "game/BKscreens.rpy", line 7282, in execute frame: File "game/BKscreens.rpy", line 7284, in execute has vbox xfill True File "game/BKscreens.rpy", line 7371, in execute hbox spacing 6: File "game/BKscreens.rpy", line 7372, in execute hbox box_wrap True: File "game/BKscreens.rpy", line 7374, in execute for status in [("away", "away.webp"), ("farm", "farm.webp"), ("rest", "rest.webp"), ("scheduled", "scheduled.webp"), ("half-shift", "half.webp"), ("master bedroom", "master.webp"), ("work&whore", "ww.webp"), ("naked", "naked.webp"), ("negative fixation", "negfix.webp"), ("not naked", "not_naked.webp"), ("not work&whore", "not_ww.webp")]: File "game/BKscreens.rpy", line 7376, in execute if status: File "game/BKscreens.rpy", line 7377, in execute button action ToggleDict(persistent.show_girl_status, status[0]) hovered SetScreenVariable("current_status", status[0]) unhovered SetScreenVariable("current_status", ""): File "game/BKscreens.rpy", line 7378, in execute if persistent.show_girl_status[status[0]]: File "<screen language>", line 7378, in <module> KeyError: u'scheduled' Windows-8-6.2.9200 Ren'Py 7.3.5.606 Brothel King 0.2 v210105 Tue Jan 05 13:14:59 2021

Yeah it's because you are using an older version of persistent dictionary 'persistent.show_girl_status'. There is a built-in repair when you access the 'girls' tab. Can you go to the girls tab first, then see if it fixes your problem?

If not, you can use the console and type:

Code: [Select]

del persistent.show_girl_status
Then restart the game.

DougTheC · « **Reply #1053 on:** January 07, 2021, 11:28:48 pm »

Gizel in foreground and background, after she defeats Arios templar, and MC says You don't want to fight me:

hide gizel was commented out for some reason.

vadi92 · « **Reply #1054 on:** January 09, 2021, 04:37:07 pm »

If we talk about typos here. Its straight not straigth

alpha_and_omega · « **Reply #1055 on:** January 10, 2021, 10:03:07 pm »

I have some remarks on the mouseover-toolbox for the "Brothel" button on the main-screen.

Consisteny:
- The {b} that is currently after "Advertising" is off. It could be placed in front of "Advertising", completely removed or (my favorite) one could set {b}{/b} around "Advertising", "Security" and "Maintenance".
- The "." in front of \nSecurity has to be removed, otherwise double dots.

Quality of life/display:

I know that the balance between showing as little as possible and as much as necessary is hard to hit.
The following propositions might work for me, but maybe not for you / Goldo, so please take them with a grain of salt.
The overall aim of these proposition is a more lisible toolbox:

(click to show/hide)

Code: [Select]

        def get_ASM_report(self, short=False):
            msg = ""

            cust, extra = self.customer_count, self.customer_count_dict["special"]

            msg += "{b}Advertising{/b}: " + brothel.count_customers_description(short=True)

            if extra and not short:
                msg += " (including " + str_int(extra) + " from girl or brothel effects)"

            msg += "\n{b}Security{/b}: The threat level is " + self.estimate_threat_level(contrast=True) + "."

            msg += "\n{b}Maintenance{/b}: " + maintenance_desc[self.get_cleanliness()]

            return msg

- The word "report" is of little to no value. It could be left out entierly.
- Advertising: Use of count_customers_description(short=True) in the toolbox for the Home screen, and the detailed count_customers_description() in the toolbox for the dedicated Brothel screen.

(click to show/hide)

Code: [Select]

        def count_customers_description(self, short=False):

            # cust_nb, adv_cust_nb, girl_cust_nb = self.customer_count, self.cust_nb_dict["advertising"], self.cust_nb_dict["special"]
            try:
                base_cust_nb = self.customer_count - self.customer_count_dict["advertising"] - self.customer_count_dict["special"]
            except:
                self.update_customer_count()
                base_cust_nb = self.customer_count - self.customer_count_dict["advertising"] - self.customer_count_dict["special"]

            if short:
                des = "{b}~%s{/b} customers" % self.customer_count

                if self.customer_count != base_cust_nb:
                    des += " ("

                    if self.customer_count_dict["advertising"]:
                        des += event_color["good"] % (str_int(self.customer_count_dict["advertising"]) + " ads")
                        if self.customer_count_dict["special"]:
                            des += ", "
                    if self.customer_count_dict["special"]:
                        des += event_color["good"] % (str_int(self.customer_count_dict["special"]) + " effects")

                    des += ")"
            
            else:
                des = "{b}%s customers{/b} are expected tonight" % self.customer_count

                if self.customer_count != base_cust_nb:
                    des += " ("
 
                    if self.customer_count_dict["advertising"]:
                        des += event_color["good"] % ("+" + str_int(self.customer_count_dict["advertising"]) + " from advertising")
                        if self.customer_count_dict["special"]:
                            des += ", "
                    if self.customer_count_dict["special"]:
                        des += event_color["good"] % ("+" + str_int(self.customer_count_dict["special"]) + " from girls and brothel effects")

                    des += ")"

            return des + "."

- Security: "The threat to your brothel is ..." -> "The threat level is ..."
- Maintenance: Just slightly shortening the maintenace_desc in BKinit_variables.

(click to show/hide)

Code: [Select]

    maintenance_desc = {"clean" : "Your brothel is " + event_color["good"] % "{b}clean{/b}" + ".",
                    "clean enough" : "Your brothel is " + event_color["a little good"] % "{b}clean enough{/b}" + ".",
                    "dusty" : "Your brothel is " + event_color["average"] % "{b}dusty{/b}" + ".",
                    "dirty" : "Your brothel is " + event_color["a little bad"] % "{b}dirty{/b}" + ".",
                    "disgusting" : "Warning! Your brothel is " + event_color["bad"] % "{b}disgusting{/b}" + "!",
                    "fire" : event_color["very bad"] % "Warning!!! Your brothel is at risk of a fire!"
                    }

These small modifications combined lead to a cleaner toolbox and bigger script. See attachments for a before-after comparison.

-----
Edit:
There is also a small anomaly in the contract descriptions.
The organiser's name loses its capital letters, though I don't know why.

Should say "Brothel Master Quinn" but shows as "Brothel master quinn".

DougTheC · « **Reply #1056 on:** January 11, 2021, 05:39:22 am »

Quote from: alpha_and_omega on January 10, 2021, 10:03:07 pm

I have some remarks on the mouseover-toolbox for the "Brothel" button on the main-screen.

I support shortening the mouseover toolbox display, and bolding changes as suggested.
Also the black font on status security "normal" and possible other statuses is nearly invisible on most room backgrounds even with the added top area gray filter.

DougTheC · « **Reply #1057 on:** January 12, 2021, 12:29:27 am »

Would help to exclude girls away on quests or classes from showing in Resting numbers on brothel report summary for Today due to scheduler status (and for Yesterday also if not already).

DougTheC · « **Reply #1058 on:** January 13, 2021, 01:15:47 am »

Favorite line:

(click to show/hide)

Typos as found:

(click to show/hide)

Jman · « **Reply #1059 on:** January 13, 2021, 05:39:18 am »

Counter-proofing:

(click to show/hide)

lolzoke · « **Reply #1060 on:** January 14, 2021, 04:36:56 am »

I have major random performance issues with this version. The game will run cleanly on one day, but I end the day to the next and the game is almost unplayable due to slow down that increases the longer I don't end that day. Sometimes it will be laggy, and then the lag will go away during that day. Sometimes the game will just lag into a freeze and CTD. Doesn't seem to matter if its a new game or not. Anyone have any experience with this?

I was also told of an event in The "Guild Quarter" for a shop of some sort but I've explored at least 10 times a day and nothing has happened. Is this ingame or did I miss a trigger somehow?

DougTheC · « **Reply #1061 on:** January 14, 2021, 11:25:43 am »

Quote from: lolzoke on January 14, 2021, 04:36:56 am

I have major random performance issues with this version. The game will run cleanly on one day, but I end the day to the next and the game is almost unplayable due to slow down that increases the longer I don't end that day. Sometimes it will be laggy, and then the lag will go away during that day. Sometimes the game will just lag into a freeze and CTD. Doesn't seem to matter if its a new game or not. Anyone have any experience with this?

I was also told of an event in The "Guild Quarter" for a shop of some sort but I've explored at least 10 times a day and nothing has happened. Is this ingame or did I miss a trigger somehow?

I have had some repeated lags, but that happens often with my PC.

Here is the full message for the guild quarter event, which should help: "The merchandise is brought to the guild quarter on the first Tuesday of every month. Look for a private club called 'Mania', and show them the amulet.
Don't expect any more intel from me, this is getting too dangerous. My cover is nearly blown, I'm out."

vadi92 · « **Reply #1062 on:** January 14, 2021, 04:34:36 pm »

Quote from: lolzoke on January 14, 2021, 04:36:56 am

I have major random performance issues with this version. The game will run cleanly on one day, but I end the day to the next and the game is almost unplayable due to slow down that increases the longer I don't end that day. Sometimes it will be laggy, and then the lag will go away during that day. Sometimes the game will just lag into a freeze and CTD. Doesn't seem to matter if its a new game or not. Anyone have any experience with this?

I was also told of an event in The "Guild Quarter" for a shop of some sort but I've explored at least 10 times a day and nothing has happened. Is this ingame or did I miss a trigger somehow?

I have the same issue after chapter 2 the more girl i get the more laggy its became.

Leortha · « **Reply #1063 on:** January 14, 2021, 09:57:27 pm »

Quote from: vadi92 on January 14, 2021, 04:34:36 pm

Quote from: lolzoke on January 14, 2021, 04:36:56 am
I have major random performance issues with this version. The game will run cleanly on one day, but I end the day to the next and the game is almost unplayable due to slow down that increases the longer I don't end that day. Sometimes it will be laggy, and then the lag will go away during that day. Sometimes the game will just lag into a freeze and CTD. Doesn't seem to matter if its a new game or not. Anyone have any experience with this?

I was also told of an event in The "Guild Quarter" for a shop of some sort but I've explored at least 10 times a day and nothing has happened. Is this ingame or did I miss a trigger somehow?
I have the same issue after chapter 2 the more girl i get the more laggy its became.

Are you on the most recent version of the game? This sounds a lot like a bug that was squashed a couple of months ago. There was a lot of discussion on the board about fixing issues of the time it takes to do EndOfDay getting longer and longer as the game went on. If this is on the most recent version, then we may have that bug resurfacing.

DougTheC · « **Reply #1064 on:** January 14, 2021, 11:37:19 pm »

Quote from: Leortha on January 14, 2021, 09:57:27 pm

Quote from: vadi92 on January 14, 2021, 04:34:36 pm
Quote from: lolzoke on January 14, 2021, 04:36:56 am
I have major random performance issues with this version. The game will run cleanly on one day, but I end the day to the next and the game is almost unplayable due to slow down that increases the longer I don't end that day. Sometimes it will be laggy, and then the lag will go away during that day. Sometimes the game will just lag into a freeze and CTD. Doesn't seem to matter if its a new game or not. Anyone have any experience with this?
I have the same issue after chapter 2 the more girl i get the more laggy its became.

Are you on the most recent version of the game? This sounds a lot like a bug that was squashed a couple of months ago. There was a lot of discussion on the board about fixing issues of the time it takes to do EndOfDay getting longer and longer as the game went on. If this is on the most recent version, then we may have that bug resurfacing.

The symptoms seem fairly different (bolding added), making suspect some more-recent change, like if girl action logging was modified. General logging has apparently not been implemented as proposed in other thread, so perhaps Goldo can go through recent changes that would scale with number of girls, or do general timing runs.

HentHighSchool Development Forum

News:

Author Topic: Test version for 0.2 (Read 129848 times)

DougTheC

Re: Test version for 0.2

Freimann

Re: Test version for 0.2

Goldo

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2

vadi92

Re: Test version for 0.2

alpha_and_omega

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2

Jman

Re: Test version for 0.2

lolzoke

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2

vadi92

Re: Test version for 0.2

Leortha

Re: Test version for 0.2

DougTheC

Re: Test version for 0.2