HentHighSchool Development Forum

Please login or register.

Login with username, password and session length
collapse
* Recent Posts
Event preview? by HypnoKitten
[Today at 09:39:30 pm]


Re: [MOD][1.9.3][YAOI Event] Late Game GYM event Version 0.5 by Tyralion
[Today at 08:49:37 pm]


Re: Girl packs by Bakkis15
[Today at 08:43:59 pm]


Re: Futanari Overhaul Mod!! (v1.0) by Llamaking
[Today at 08:37:52 pm]


Re: [Renpy] Dragon Ball Infinity V0.3 by Masquerade
[Today at 07:48:08 pm]


Pages: [1] 2   Go Down

Author Topic: Experimental patch - Daily events  (Read 5160 times)

Goldo

  • Moderator
  • Sr. Member
  • *****
  • Offline Offline
  • Posts: 473
    • View Profile
Experimental patch - Daily events
« on: March 24, 2018, 11:47:24 am »

Hi guys,

I am releasing new girl events for testing as a separate patch. I meant to include this with 0.13 back in January, but got overwhelmed by the amount of writing required.

Experimental patch: http://www.mediafire.com/file/427apjb16xu9uc2/Game_0.13_-_day_events_test.zip

These new events have a 10-20% chance of coming up on any given day. For testing purposes, you can edit those values in BKstart.rpy lines 211 and 212:
Quote
        daily_events = [StoryEvent("random_night_events", type="night", chance=0.1, once=False),
                        StoryEvent("random_morning_events", type="morning", chance=0.2, once=False),


There are dozens of new combinations possible, so I couldn't test them all. Issues could include the following:
- Crashes on some specific paths
- Pictures or sounds being off
- Typos or missing text
- Girl reactions not being fully balanced

Please report everything here (not in the bug section). Once it is more or less stable, I will release those events as part of the main patch.
« Last Edit: May 07, 2018, 11:23:07 pm by Goldo »
Logged

Zamadaga

  • Newbie
  • *
  • Offline Offline
  • Posts: 2
    • View Profile
Re: Experimental patch - Daily events
« Reply #1 on: March 25, 2018, 05:17:37 am »

Here's a report for you!

Night event trigger, chose the "Kiss her" option, got this:

Code: [Select]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKendday.rpy", line 46, in script call
    call play_events(type = "night") from _call_play_events
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 594, in script call
    call random_night_girl_event(girl, room) from _call_random_night_girl_event #!
  File "game/BKday_events.rpy", line 846, in script call
    call night_girl_perform()
  File "game/BKday_events.rpy", line 2890, in script
    $ attitude = girl.get_sex_attitude(fix_name="kissing") + girl.get_love() - girl.get_fear()
  File "game/BKday_events.rpy", line 2890, in <module>
    $ attitude = girl.get_sex_attitude(fix_name="kissing") + girl.get_love() - girl.get_fear()
TypeError: get_sex_attitude() got an unexpected keyword argument 'fix_name'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKendday.rpy", line 46, in script call
    call play_events(type = "night") from _call_play_events
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 594, in script call
    call random_night_girl_event(girl, room) from _call_random_night_girl_event #!
  File "game/BKday_events.rpy", line 846, in script call
    call night_girl_perform()
  File "game/BKday_events.rpy", line 2890, in script
    $ attitude = girl.get_sex_attitude(fix_name="kissing") + girl.get_love() - girl.get_fear()
  File "[snipped filepath]\Brothel_King-pc\renpy\ast.py", line 827, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "[snipped filepath]\Brothel_King-pc\renpy\python.py", line 1764, in py_exec_bytecode
    exec bytecode in globals, locals
  File "game/BKday_events.rpy", line 2890, in <module>
    $ attitude = girl.get_sex_attitude(fix_name="kissing") + girl.get_love() - girl.get_fear()
TypeError: get_sex_attitude() got an unexpected keyword argument 'fix_name'

Windows-8-6.2.9200
Ren'Py 6.99.13.2919
Brothel King 0.13

I snipped out the filepath but left the rest untouched.

---

Edit and followup - The "Join her in bed" option also throws an exception. To keep the size of the post small: Error appears to be that the variable "attitude" appears to be undefined. game/BKday_events.rpy, line 2825, "if attitude > 150: ".
« Last Edit: March 25, 2018, 06:03:59 am by Zamadaga, Reason: additional information »
Logged

Goldo

  • Moderator
  • Sr. Member
  • *****
  • Offline Offline
  • Posts: 473
    • View Profile
Re: Experimental patch - Daily events
« Reply #2 on: April 07, 2018, 11:19:53 am »

I have updated the patch, those events should now work.
Logged

scoota33

  • Newbie
  • *
  • Offline Offline
  • Posts: 3
    • View Profile
Re: Experimental patch - Daily events
« Reply #3 on: April 09, 2018, 04:40:58 am »

girl trying to sneak into room - chose spend the night with her

Code: [Select]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKendday.rpy", line 914, in script call
    call play_events(type = "morning") from _call_play_events_1 # Note: Morning events are set with the new day's date: beware of the confusion
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 481, in script
    $ girl.change_stat(act)
  File "game/BKday_events.rpy", line 481, in <module>
    $ girl.change_stat(act)
TypeError: change_stat() takes at least 3 arguments (2 given)

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKendday.rpy", line 914, in script call
    call play_events(type = "morning") from _call_play_events_1 # Note: Morning events are set with the new day's date: beware of the confusion
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 481, in script
    $ girl.change_stat(act)
  File "C:\Games\henthigh\Brothel_King-0.13\Brothel_King-pc\renpy\ast.py", line 827, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Games\henthigh\Brothel_King-0.13\Brothel_King-pc\renpy\python.py", line 1764, in py_exec_bytecode
    exec bytecode in globals, locals
  File "game/BKday_events.rpy", line 481, in <module>
    $ girl.change_stat(act)
TypeError: change_stat() takes at least 3 arguments (2 given)

Windows-8-6.2.9200
Ren'Py 6.99.13.2919
Brothel King 0.13
Logged

1tomadeira

  • Full Member
  • ***
  • Offline Offline
  • Posts: 216
    • View Profile
Re: Experimental patch - Daily events
« Reply #4 on: April 10, 2018, 01:01:40 am »

After this patch and after the first event happened the girl started to refuse work all days, even though she's 10/10 in love and fear. Something was changed on love/fear bonuses, and if yes this is intended?

I have no idea how to put her to work besides changing her to whore, I tried every option.

These mini events still occur though, with zero problems so far. She has an orange trait btw.
Logged

1tomadeira

  • Full Member
  • ***
  • Offline Offline
  • Posts: 216
    • View Profile
Re: Experimental patch - Daily events
« Reply #5 on: April 10, 2018, 06:36:06 pm »

The game crashed when ending day and I had a traceback file. It seems it has an infinte loop when giving xp at line 735. Since it excedes the 20000 char limit I will say the begining and what it repeats.

(click to show/hide)

What repeats until the end

(click to show/hide)

And finally at the very end:

(click to show/hide)

edit: The crash happens when 2 girls have the confession perk, just tested it now. It happens 100% of the time. Probably both cycles are looping themselves.

________________________________

edit to avoid another post: another issue, also when ending day, fortunely this one doesn't crash game, appears on clipboard.

(click to show/hide)

This time I couldn't detect what's provoking the issue, although it also seems a perk related one.
« Last Edit: April 11, 2018, 01:46:33 am by 1tomadeira »
Logged

Dragonblood

  • Hero Member
  • *****
  • Offline Offline
  • Posts: 1361
  • Code monkey
    • View Profile
Re: Experimental patch - Daily events
« Reply #6 on: April 11, 2018, 06:59:08 am »

I think I see what at least part of the problem is with the JP spillover.

Here's the call from girl.stat_spillover which gives the JP to other girls:
Code: [Select]
g.change_jp(stat, chg * eff, apply_boost=False, spillover=False) # spillover=False is needed to avoid an infinite feedback loop
However, here's the signature of girl.change_jp:
Code: [Select]
def change_jp(self, value, job, apply_boost = True, spillover=True):
That "stat" variable at the start of the spillover's call needs to be removed. After that, the call and the signature should match, preventing at least that TypeError.
Logged

Goldo

  • Moderator
  • Sr. Member
  • *****
  • Offline Offline
  • Posts: 473
    • View Profile
Re: Experimental patch - Daily events
« Reply #7 on: April 12, 2018, 05:58:49 pm »

Hi guys!

Sorry about that, as always I lack the time and opportunity to test some of the changes I make thoroughly :(

I have fixed the patch (and tested it properly): the perk should work as intended now.
Logged

kite80

  • Full Member
  • ***
  • Offline Offline
  • Posts: 117
    • View Profile
Re: Experimental patch - Daily events
« Reply #8 on: April 12, 2018, 06:38:14 pm »

Thank you Goldo, you're doing well don't worry, just let some tests to us players and count on our help for that ;-)
Logged

1tomadeira

  • Full Member
  • ***
  • Offline Offline
  • Posts: 216
    • View Profile
Re: Experimental patch - Daily events
« Reply #9 on: April 12, 2018, 10:05:59 pm »

No need to say sorry, we're glad to help on testing the game.
Logged

AnalogSquirrel

  • Jr. Member
  • **
  • Offline Offline
  • Posts: 53
    • View Profile
Re: Experimental patch - Daily events
« Reply #10 on: April 17, 2018, 12:23:47 am »

Found an error.  It came up during one of the daily events in the strip club:
Code: [Select]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKendday.rpy", line 46, in script call
    call play_events(type = "night") from _call_play_events
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 595, in script call
    call random_night_girl_event(girl, room) from _call_random_night_girl_event #!
  File "game/BKday_events.rpy", line 1612, in script call
    call night_girl_perform()
  File "game/BKday_events.rpy", line 4368, in script
    if fix in ["double penetration", "multiple orgasms"]:
SyntaxError: invalid syntax (game/BKday_events.rpy, line 4371)

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKendday.rpy", line 46, in script call
    call play_events(type = "night") from _call_play_events
  File "game/BKevents.rpy", line 271, in script call
    call display_events(ev_list) from _call_display_events
  File "game/BKevents.rpy", line 281, in script call
    $ ev.play()
  File "game/BKday_events.rpy", line 595, in script call
    call random_night_girl_event(girl, room) from _call_random_night_girl_event #!
  File "game/BKday_events.rpy", line 1612, in script call
    call night_girl_perform()
  File "game/BKday_events.rpy", line 4368, in script
    if fix in ["double penetration", "multiple orgasms"]:
  File "D:\Users\johnh\Downloads\Brothel_King-0.13\Brothel_King-pc\renpy\ast.py", line 1681, in execute
    if renpy.python.py_eval(condition):
  File "D:\Users\johnh\Downloads\Brothel_King-0.13\Brothel_King-pc\renpy\python.py", line 1793, in py_eval
    code = py_compile(code, 'eval')
  File "D:\Users\johnh\Downloads\Brothel_King-0.13\Brothel_King-pc\renpy\python.py", line 597, in py_compile
    raise e
SyntaxError: invalid syntax (game/BKday_events.rpy, line 4371)

Windows-8-6.2.9200
Ren'Py 6.99.13.2919
Brothel King 0.13
Logged

kite80

  • Full Member
  • ***
  • Offline Offline
  • Posts: 117
    • View Profile
Re: Experimental patch - Daily events
« Reply #11 on: April 18, 2018, 01:33:11 pm »

If you can open BKday_events you can fix it in this way (I suggest to use editra since you will have the code lines with index):

find line 4371 which contains this code:

Code: [Select]
elif fix = "bukkake":
And change like this:

Code: [Select]
elif fix == "bukkake":
An if statement needs a == operator, that should be the cause of the error
Logged

AnalogSquirrel

  • Jr. Member
  • **
  • Offline Offline
  • Posts: 53
    • View Profile
Re: Experimental patch - Daily events
« Reply #12 on: April 18, 2018, 10:57:51 pm »

If you can open BKday_events you can fix it in this way (I suggest to use editra since you will have the code lines with index):

find line 4371 which contains this code:

Code: [Select]
elif fix = "bukkake":
And change like this:

Code: [Select]
elif fix == "bukkake":
An if statement needs a == operator, that should be the cause of the error

Seems obvious once pointed out  ;)  I've used enough different languages that it's getting hard to keep track of = vs == for comparisons.

Thanks!
Logged

Goldo

  • Moderator
  • Sr. Member
  • *****
  • Offline Offline
  • Posts: 473
    • View Profile
Re: Experimental patch - Daily events
« Reply #13 on: April 21, 2018, 11:23:42 am »

Patch updated, thanks for spotting that
Logged

Dragonblood

  • Hero Member
  • *****
  • Offline Offline
  • Posts: 1361
  • Code monkey
    • View Profile
Re: Experimental patch - Daily events
« Reply #14 on: April 30, 2018, 10:16:03 pm »

Just noticed what looks like a typo in BKday_events.rpy, line 1685:

MC.add_effect(eff)

Unless I'm mistaken, that should be:

MC.add_effects(eff)
Logged
Pages: [1] 2   Go Up
 


anything
SimplePortal 2.3.3 © 2008-2010, SimplePortal